Bug #126
Themes with no information are allowed
| Status: | Invalid | Start date: | 2009-03-26 | |
|---|---|---|---|---|
| Priority: | Undecided | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | - | |||
| Target version: | - | |||
| PHP Version: |
Description
TCM allows a user to choose a theme with no information other than necessary details in details.xml, as long as all the necessary files exist (main_template, css...) then the user can choose it. The files should be checked for size and/or content, and if they are empty or 0 bytes in size then an error should display.
History
Updated by Alex Cartwright about 3 years ago
Can you explain more on this?
Updated by Joe Davison about 3 years ago
Yeah - basically if you give TCM a theme with a bunch of empty files, apart from details.xml, you will still be allowed to use the theme, since the theme is empty, the site will be. A warning needs to be displayed that there are empty files in use.
Updated by Robert Clipsham about 3 years ago
Not really a bug in my opinion. Checking the size of the main_template.html file or checking for {*} might be a better way to handle it. I doubt this would be an issue very often, unless you are creating a theme in which case you'll know that it's empty. If this gets "fixed", I can see another bug report later on from an annoyed themer when they can't start with a blank main_template.html file. Checking the CSS files isn't an option as they are free to be named however the themer chooses.
Updated by Alex Cartwright about 3 years ago
- Status changed from New to Invalid
Agreed, it's not an issue to worry about.